Any time I’m replacing an icon and want to change this setting I have to do it two times (and press OK in between each time and open the dialog again).
(Also, just noticed, if you’re changing the default icon on an existing toolbar, and want to change this setting, even the light side icon doesn’t get saved. You have to do that twice too.)
Hi just confirming if this is still being fixed, I don’t see the issue in the yt link above. However, I can confirm the recolor isn’t working in Rhino 8 SR15 (8.15.24352.13001)
Re-reading this thread and I read two issues in your post @bfrederick , the old recolour was causing a lot of weird bugs, there is a way to make the recolour work however.
If you open the SVG up in a text editor you can add fill-dark and/or stroke-dark as properties. If your icon is using fill="black" you would change this to fill="black" fill-dark="white"
Thanks for the tool! I made a little one but didn’t publish anything yet, really glad this is working for you. You can of course choose any colour and even have elements that only show in dark mode and/or only show in light mode. So it should be more powerful than the uncontrollable auto-flipping behaviour.
I think I know why this is, it’s something I’m working on, I need to unify some backend SVG stuff and that might fix this.
Another thing I’m noticing is that svgs won’t render in the toolbar if they’re larger than 48px x 48px. Given that there are many open source svg sources to download online and many sizes, I guess it might be worth making that clear somewhere in the docs that svgs should be max 48px x 48 px. Or handle replacing the width and height svg attribute values automatically in the editor upon loading. Having this new ability to customize icons via svg attributes is fantastic. Thanks!
Yep. I see this. It’s supposed to strip out the height/width so it defaults to 100% x 100%.
Good find @bfrederick, thanks for this, fixing this will prevent some other bugs too!