Creating cut glass whisky glass

The classic approach is moddelig the way this is produced. Revolve the base glass shape and then model the cutting path and shape of the cutter and boolean difference.

Or test out SubD and revolve and join. Here is an example of that approach on the decanter: