IsPolyCurve(), IsPolyline() vs. IsCurve() behavior

silvano · May 31, 2023, 4:42pm

IsPolyCurve() and IsPolyline() use rhutil.coercecurve(object_id, raise_if_missing=True) but IsCurve(object_id, raise_if_missing=False). This seems odd to me or is there a reason? In my opinion none of them should raise.

I changed it in a fork. Let me know if I should make a PR. Thanks!

James_Parrott · May 31, 2023, 4:48pm

You have a point if this was recently written code, or your own application. I’m not the maintainer of rhinoscriptsyntax and I can’t speak for McNeel. But my two pence is: in a commercial code base, for a product that was long since shipped, one that many different plug-ins and many users’ code already relies on, a nicety does not merit a breaking change.

github.com

mcneel/rhinoscriptsyntax/blob/c49bd0bf24c2513bdcb84d1bf307144489600fd9/Scripts/rhinoscript/curve.py#L2841


      
                CircleCenterPoint
                CircleCircumference
                CircleRadius
              """
              curve = rhutil.coercecurve(curve_id, -1, True)
              if tolerance is None or tolerance < 0:
                  tolerance = Rhino.RhinoMath.ZeroTolerance
              return curve.IsCircle(tolerance)
          
          

          
def IsCurve(object_id):
              """Verifies an object is a curve
              Parameters:
                object_id (guid): the object's identifier
              Returns:
                bool: True or False
              Example:
                import rhinoscriptsyntax as rs
                object = rs.GetObject("Select a curve")
                if rs.IsCurve(object):
                    print "The object is a curve."

github.com

mcneel/rhinoscriptsyntax/blob/c49bd0bf24c2513bdcb84d1bf307144489600fd9/Scripts/rhinoscript/curve.py#L3126


      
                            print "The point is not on the curve"
              See Also:
                IsCurve
              """
              curve = rhutil.coercecurve(object_id, segment_index, True)
              point = rhutil.coerce3dpoint(point, True)
              rc, t = curve.ClosestPoint(point, Rhino.RhinoMath.SqrtEpsilon)
              return rc
          
          

          
def IsPolyCurve(object_id, segment_index=-1):
              """Verifies an object is a PolyCurve curve
              Parameters:
                curve_id (guid): identifier of the curve object
                segment_index (number, optional) the curve segment index if `curve_id` identifies a polycurve
              Returns:
                bool: True or False
              Example:
                import rhinoscriptsyntax as rs
                obj = rs.GetObject("Select a polycurve")
                if rs.IsPolyCurve(obj):

silvano · May 31, 2023, 4:53pm

True that, fully agreed. A breaking change like this is critical. That said, there are similar breaking changes happening from time to time in Rhino

Thanks for adding the Github links

Alain · June 1, 2023, 1:50pm

Hi,
We try to avoid breaking changes.
Please let us know if you find some.

Topic		Replies	Views
RhinoPython rs.IsPolyline raises an exception Scripting	2	346	September 16, 2019
IsCircle behaves differently between Rhinoscript and Python Scripting	7	1432	January 14, 2014
Rs.iscurve(object), true or false? Different between gh and rhino? Rhino Developer windows	2	311	November 10, 2023
Check for curvetype Scripting	8	1788	February 21, 2020
RhinoCommon, Curve.IsPolyline() returns true on non linear polyCurve Rhino Developer windows	4	417	October 5, 2021

IsPolyCurve(), IsPolyline() vs. IsCurve() behavior

Related topics