Fit Curve Opens Curve

Rhino
,
1

Odd issue with Fit Crv.3dm (170.9 KB)

I came across this closed polyline curve - when I apply FitCrv I am given a nicely smooth curve which is somehow open? It is as if the final corner (just before the seam) is ignored?

image
image2091×1050 58.4 KB

2

I would use _RebuildCrvNonUniform instead of _FitCrv since _FitCrv doesn’t really lead to a smooth curve with the inputs you mentioned. At least on the “arc” segment shown on my screenshot it adds points on the line segments.

image
image1786×1241 49.6 KB

Odd issue with Fit Crv.3dm (167.6 KB)

3

Thanks Martin, _RebuildCrvNonUniform does indeed keep the curve closed - however it does not keep the sharp corners sharp.

I suspect this is a goldilocks thing as there is no perfect curve fitting!

I was quite surprised to find a closed curve becoming open however.

image
image1065×1513 22.9 KB

4

If you want sharp corners, you’r probably have to split the curve at the corners.

I’d do this in Grasshopper. It’s simple to quickly explore different solutions…

image
image1946×574 84.9 KB

image
image2743×1141 86.4 KB

Odd issue with Fit Crv.3dm (167.9 KB)

rebuild_curve.gh (8.6 KB)

5

Hi David - so far I do not get the gap, here, at those settings in the latest build here, nor the hard corner to the right.

image
image1463×592 20.8 KB

-Pascal

6

@pascal I get the same results as the OP using Version 7 SR21 (7.21.22208.13001, 2022-07-27).

FitCrv Settings
FitCrv Settings812×46 11.3 KB

Odd issue with Fit Crv DC01.3dm (2.7 MB)

image
image1590×797 8.81 KB

7

Yeah - you’re right, sorry . Intereresting, or maybe not, that the polyline segments in the corners are just about fitting tolerance long.

Hm- as soon as the tolerance hits that segment length (.092) or above, the gap shows up. If the tolerance is set to the length of the segments in the lower corners, ‘resolution’ is lost there as well.

-Pascal

8

If the input curve is a valid closed curve then FitCrv should always output a closed curve. Looks like FitCrv needs a tune-up or the algorithm needs revising. This should go on the heap as a bug which needs fixing.

1 Like
9

Thank you all for looking at this, intriguing to see there might be a bug!

Thank you @martinsiegrist for the grasshopper script, I found this component in Kangeroo2 which does the splitting at the corners - which means I can preserve the corners accurately Split At Corners - Kangaroo 2 - Component for Grasshopper | Grasshopper Docs

1 Like