Improve how Compute handle 401 responses

gtalarico1 · September 2, 2019, 3:12am

Not sure if this is the best place to post this, but since the repo doesn’t have Issues enabled I figured I would post it here.
Let me know if there is a better place for posts like this.

When using the RhinoCompute JS library, if you have a missing or incorrect authToken (a missing letter), the computeFetchhttps://github.com/mcneel/compute.rhino3d/blob/3334d1a1bf50854b1352614333074639401722fe/src/compute.client/JavascriptClient.cs#L52 raises a JSON parsing error because the response cannot be jsonified.

I think a better behaviour would be to check if request was OK before trying calling json()
if request was not 200 raise an error stating why request failed (eg. 401 Unautorized) instead of letting json() fail with a json parsing error

github.com

mcneel/compute.rhino3d/blob/3334d1a1bf50854b1352614333074639401722fe/src/compute.client/JavascriptClient.cs#L52


},


computeFetch: function(endpoint, arglist) {
    return fetch(RhinoCompute.url+endpoint, {
            ""method"":""POST"",
            ""body"": JSON.stringify(arglist),
            ""headers"": {
                ""Authorization"": RhinoCompute.authToken,
                ""User-Agent"": `compute.rhino3d.js/${RhinoCompute.version}`
            },
    }).then(r=>r.json());
},


zipArgs: function(multiple, ...args) {
    if(!multiple)
        return args;


    if(args.length==1)
        return args[0].map(function(_,i) { return [args[0][i]]; });
    if(args.length==2)
        return args[0].map(function(_,i) {

will · September 6, 2019, 10:34am

Hey @gtalarico1, sorry for the delay. Good idea! I’ve logged this as COMPUTE-90. Pull requests welcome, of course!

We’ll open up issues on the compute repo shortly, just want to make sure that the link I added between GitHub and YouTrack is working well for us on the rhino3dm repo first! It’s tricky keeping track of and prioritising stuff if it’s all in different places