Bug? ObjectLayout() always changes layer, even if layout parameter is omitted

senorvalenz · August 27, 2021, 4:07pm

Or am I just mis-understanding how to use an optional parameter?

The line in question seems to always change the object to model space, with very unfortunate consequences if the user doesn’t realize it:

currentLayout = rs.ObjectLayout(obj,return_name=True)

Full script attached.

SV_SelectAllObjsOnObjLayers.py (1.3 KB)

dale · August 27, 2021, 6:37pm

Hi @senorvalenz,

I can see the flaw in the code. I’ve logged the issue.

https://mcneel.myjetbrains.com/youtrack/issue/RH-65424

Here is the source, if you are curious what RhinoCommon methods are used:

github.com

mcneel/rhinoscriptsyntax/blob/c49bd0bf24c2513bdcb84d1bf307144489600fd9/Scripts/rhinoscript/object.py#L923

    
      
              rc = scriptcontext.doc.Layers[index].FullPath
              if layer:
                  layer = __getlayer(layer, True)
                  index = layer.LayerIndex
                  obj.Attributes.LayerIndex = index
                  obj.CommitChanges()
                  scriptcontext.doc.Views.Redraw()
              return rc
          
          

          
def ObjectLayout(object_id, layout=None, return_name=True):
              """Returns or changes the layout or model space of an object
              Parameters:
                object_id (guid): identifier of the object
                layout (str|guid, optional): to change, or move, an object from model space to page
                  layout space, or from one page layout to another, then specify the
                  title or identifier of an existing page layout view. To move an object
                  from page layout space to model space, just specify None
                return_name[opt] = If True, the name, or title, of the page layout view
                  is returned. If False, the identifier of the page layout view is returned
              Returns:

– Dale

senorvalenz · August 28, 2021, 7:20pm

Thanks Dale. I’ll have to wrap my head around RhinoCommon before I can make use of it, but I look forward to the RhinoScript fix!

senorvalenz · September 22, 2021, 5:07pm

Hi @dale , I’m trying to fix this one but I’m running into trouble. I’m sure it’s because my understanding of using RhinoCommon within python is weak.

This guide didn’t help me much, do you have any other recommended resources?

Or can you suggest a fix to the attached script? I’m getting the following error: “Message: global name ‘rhutil’ is not defined”

SV_SelectAllObjsOnObjLayers.py (2.7 KB)

Thanks,
Steven

dale · September 23, 2021, 7:00pm

Hi @senorvalenz,

In your script, replace rhutil with rs.

Also, don’t forget to import scriptcontext.

– Dale

senorvalenz · October 4, 2021, 2:04pm

Excellent, that did the trick, thanks @dale ! Working script (command-formatted) attached:

SLAY_adn_cmd.py (3.1 KB)

Edit: updated script w following fix: rs.EnableRedraw(True) needs to be added before the return